Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove TiDB Binlog after deprecation #18576

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

*: remove TiDB Binlog after deprecation #18576

wants to merge 13 commits into from
+62 −3,593

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Sep 9, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Starting from TiDB v8.4.0, TiDB Binlog is removed after deprecation. This PR removes and updates documents related to removing TiDB Binlog.

Note:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. v8.4 This PR/issue applies to TiDB v8.4. labels Sep 9, 2024
@lilin90 lilin90 self-assigned this Sep 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2024
@lilin90 lilin90 mentioned this pull request Sep 9, 2024
Closed
15 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 9, 2024

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Benjamin2037
Benjamin2037 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 9, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Benjamin2037
Copy link
Contributor

https://docs.pingcap.com/zh/tidb/stable/sql-statement-change-drainer
696503f4-40a2-4e89-bda1-3a2d581c91a3
这几个语句的说明可能也需要删除

@lilin90
Copy link
Member Author

lilin90 commented Sep 10, 2024

https://docs.pingcap.com/zh/tidb/stable/sql-statement-change-drainer 696503f4-40a2-4e89-bda1-3a2d581c91a3 这几个语句的说明可能也需要删除

Done in f5d3bd0.

@lilin90 lilin90 requested a review from hfxsd September 10, 2024 07:21
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2024
@lilin90 lilin90 mentioned this pull request Sep 12, 2024
Open
15 tasks
lilin90
lilin90 commented Sep 13, 2024
View reviewed changes
alert-rules.md Outdated Show resolved Hide resolved
lilin90
lilin90 commented Sep 13, 2024
View reviewed changes
faq/backup-and-restore-faq.md Outdated Show resolved Hide resolved
grafana-tidb-dashboard.md Show resolved Hide resolved
identify-slow-queries.md Show resolved Hide resolved
releases/release-2.1-rc.5.md Show resolved Hide resolved
resources/doc-templates/template-concept.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@lilin90 lilin90 mentioned this pull request Sep 13, 2024
Open
15 tasks
@lilin90 lilin90 mentioned this pull request Sep 14, 2024
Open
15 tasks
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
releases/release-8.3.0.md Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
maintain-tidb-using-tiup.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 18, 2024
View reviewed changes
maintain-tidb-using-tiup.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 18, 2024
@lilin90
Copy link
Member Author

lilin90 commented Sep 18, 2024 •
edited
Loading

@Benjamin2037 has confirmed the two new commits that delete more descriptions about Pump and Drainer: ca472d7 and 3b8bf6f.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 09:51:17.207946147 +0000 UTC m=+263546.948370086: ☑️ agreed by lance6716.
  • 2024-09-19 03:16:29.690588714 +0000 UTC m=+1103859.431012653: ☑️ agreed by hfxsd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@lilin90 lilin90

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilin90 @Benjamin2037 @lance6716 @D3Hunter @hfxsd